[PATCH][Xfce-i18n] Mousepad intltoolized

Erik Harrison erikharrison at gmail.com
Wed May 11 01:34:03 CEST 2005


On 5/10/05, Daichi Kawahata <daichi.k at aioros.ocn.ne.jp> wrote:
> Hi Erik,
> 
> What I've done against the latest SVN version of Mousepad are,
> 
>     o Making package intltoolized
> 
>       With macro AC_PROG_INTLTOOL([0.33], [no-xml]), perl module
>       (XML::Parser) is never checked, I think it reduces build
>       dependency.
> 
>     o Adding files (mousepad.desktop.in, mousepad.spec.in, autogen.sh)
> 
>       These .in files might need to be corrected/rewrote by the author.
> 
>     o Moving translations in mousepad.desktop to each PO files
> 
>       I've noticed language Slovak had been illegally converted, it
>       requires to be fixed.
> 
>     o Fixing PO headers
> 
>       I've changed package name in header (Leafpad -> Mousepad), version
>       (0.2.2)
> 
>     o Changing style of autotool related files (configure.ac, Makefile.am)
> 

If you do this, from now on please make it a seperate patch from the
rest of your work. In general, bug fixes, cleanups, and feature
additions should be seperated out.

Autotools and I are not on the best of terms, so changing the style
and layout of the autotool's files confused my little brain. I would
prefer it if I could pick and choose between adding intltool support
and cleaning up some formatting and stylistic files.

>     o Removing extra files from SVN repository
> 
>       mousepad.desktop, src/.deps/*.Po files, gettext related files in po
>       directory
> 
>     o Modifying source codes to reduce warnings (with -W -Wall -Wformat=2)
> 

Also split this out, when you can, from your other work, and let me
know what warnings you are fixing.

> I'll welcome your comments, but if you'd prefer bugzilla, let me know.
> 

Also you've changed the copyright info from (c) me to (c) The Xfce
Development Team.

It isn't copyright the Xfce development team, anymore than Xfmedia is.
It's my copyrighted work of Tarot's copyrighted work on Leafpad. And
I'm not sure Jasper and Olivier want to claim any copyright of my ugly
hack ;-).

If you could rebuild the patch minus the copyright changes, I'll apply
it. And I really, truly appreciate it Daichi

> Regards,
> --
> Daichi
> 
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce4-dev
> 
> 
> 


-- 
CAPS LOCK: ITS LIKE THE CRUISE CONTROL FOR AWESOME
-Erik



More information about the Xfce4-dev mailing list