Incorrect xfce_framebox_add() implementation

Brian J. Tarricone bjt23 at cornell.edu
Wed Aug 31 07:01:04 CEST 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeff Franks wrote:
> Brain,
> 
> Another thing I've noticed about XfceFramebox is that I have no way of 
> setting the frame text or indent without duplicating the entire code 
> block in xfce_framebox_new(). I can provide a patch if you like that 
> would make 'indent' a property, provide a text getter and setter and add 
> the xfce_real_framebox_add() function (making XfceFramebox language 
> binding friendly :-) ).

I'm not sure what the problem is... Why is it necessary to change indent
or label text after construction?  XfceFramebox itself doesn't have that
functionality, so...  Or am I missing something?  (Probably.)

Otherwise, an 'indent' property sounds fine.  Would it be best to have:
a) a 'label-text' property
b) getters/setters for the label text
c) both

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDFTmQ6XyW6VEeAnsRAt7NAKCqa2fKowu3AsUkB4zuHVLgfL4WNQCePyBL
LPH/HJTs5NUQfSOx4wNk31s=
=2CgS
-----END PGP SIGNATURE-----



More information about the Xfce4-dev mailing list