Incorrect xfce_framebox_add() implementation

Jeff Franks jcfranks at
Wed Aug 31 06:49:31 CEST 2005

Brian J. Tarricone wrote:

>Actually, that widget is just constructed weirdly.  It's derived from
>GtkFrame, which is a GtkBin, and yet it uses gtk_box_pack_start() to add
>something to it, when it's not a GtkBox.  Well, there's a GtkHBox in the
>GtkFrame for some reason.  Not sure why we don't just add stuff directly
>to the GtkFrame.  I guess maybe for the padding.  I dunno.
Because GtkFrame is a bin widget, my impression is that Olivier found it 
an easy way to give a GtkHBox a label.

>Ok, xfce_framebox_add() is marked as deprecated, and gtk_container_add()
>and gtk_container_remove() are hooked up properly.
>Benny, can you verify that changing instances of GtkType to GType won't
>break ABI or anything?  They should just be typedefs to guint32 or
>gulong or somesuch, IIRC...
>Danny: not sure, but you make have to 'fix' pyxfce.
GtkType is a typedef for GType so there will be no break.


More information about the Xfce4-dev mailing list