xfwm4 shorcut editor is broken

[Olivier Fourdan]

Jean-Francois

Did you actually test you change if the user has just "Default" as
keytheme?

Cheers,
Olivier.

On Sun, 2004-09-26 at 10:14, Olivier Fourdan wrote:
> Jean-Francois
> 
> The setting dialog crashes right away now!
> 
> bt follows:
> 
> #0  0x001771ea in strcmp () from /lib/tls/libc.so.6
> #1  0x0032aa29 in _xfce_rc_simple_get_entries ()
>    from /usr/lib/libxfce4util.so.1
> #2  0x0032845d in xfce_rc_get_entries () from /usr/lib/libxfce4util.so.1
> #3  0x00782bb4 in loadtheme_in_treeview (ti=0x8a99b80, data=0x1)
>     at xfwm4_shortcuteditor.c:302
> #4  0x0078b471 in setup_dialog (itf=0x891cd88) at xfwm4_plugin.c:1837
> #5  0x0804a765 in show_cb ()
> #6  0x00103fe0 in mcs_manager_process_event ()
>    from /usr/lib/libxfce4mcs-manager.so.0
> #7  0x0804a7b0 in manager_event_filter ()
> #8  0x002da658 in gdk_event_get_graphics_expose ()
>    from /usr/lib/libgdk-x11-2.0.so.0
> #9  0x002db13b in gdk_x11_register_standard_event_type ()
>    from /usr/lib/libgdk-x11-2.0.so.0
> #10 0x002dc91d in gdk_x11_register_standard_event_type ()
>    from /usr/lib/libgdk-x11-2.0.so.0
> #11 0x002dcab1 in gdk_x11_register_standard_event_type ()
>    from /usr/lib/libgdk-x11-2.0.so.0
> #12 0x008cfc1b in g_main_context_dispatch (context=0x88c4788) at
> gmain.c:1942
> #13 0x008d1844 in g_main_context_iterate (context=0x88c4788, block=1,
>     dispatch=1, self=0x88c6100) at gmain.c:2573
> #14 0x008d1b0a in g_main_loop_run (loop=0x88c4f88) at gmain.c:2777
> #15 0x07a9d903 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
> #16 0x0804ab47 in main ()
> 
> 
> On Sat, 2004-09-25 at 23:55, Jean-François Wauthy wrote:
> > On Sat, 2004-09-25 at 19:38, Jean-François Wauthy wrote:
> > > > > Please make sure Botsie gets notified, as he was planning to release
> > > > > beta this WE.
> > > > > 
> > > > ok this should be fixed now, user can create and delete his own
> > > > keybinding themes and Default (and other not writable themes) cannot be
> > > > edited
> > > Ah... xfwm4 now merges themes, so it was possible to edit "Default"
> > > now...
> > yes, good thing but finally i think it's better to keep (at least)
> > "Default" read-only, if you don't agree i can easily change that and
> > allow edition of all theme or all but "Default".
> > 
> > > Cheers,
> > > Olivier.
-- 
 - Olivier Fourdan - fourdan at xfce.org - http://www.xfce.org -