Fwd: Re: SAWFISH and XFCE4

[Willy Gardiol]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


I am forwarding this messagefrom the sawfish mailing list, it seems to be a 
bug in the XFCE4 pager actually...

So i tried and i came out with the attached patch (sorry, it is against 4.0.6 
i do not know how to access CVS and latest branch).

It ocmpletely fix the problem, it is based on and old libwnck patch, which has 
probably been applied after netk-pager was copied from libwnck.

Can you apply this patch to xfce4? 

thanks 

- ----------  Messaggio inoltrato  ----------

Subject: Re: SAWFISH and XFCE4
Date: Sunday 12 September 2004 01:12
From: GSR - FR <famrom at infernal-iceberg.com>
To: sawfish-list at gnome.org

willy at gardiol.org (2004-09-12 at 0011.36 +0200):
> No, i have checked, my libwnck already includes that patch... that is not
> the reason.
>
> LibWNCK is libwnck-2.6.2.1, and the patch is already included as i can see.

XFCE also has code that does pager tasks (quick download and grep),
are you sure it does all perfectly? I saw in the file
libxfcegui4-4.0.6/libxfcegui4/netk-pager.c a call like:

netk_screen_move_viewport (pager->priv->screen, viewport_x, viewport_y);

after a

workspace_at_point (pager, event->x, event->y, &viewport_x, &viewport_y);

which seems pretty similar to the libwnck status previously to the
patch linked in the bug I pointed. That is, no modification of coords
to make all be "non fractional screens".

And greeping for wnck I only get

AUTHORS:libxfcegui4 includes libwnck by Havoc Pennington <hp at redhat.com>

so it does not seem to use it by "#include", which could mean that
bugs fixed in one place are not fixed in another. You could verify by
checking which libs it requires (package, ldd or whichever you can
think of as good method).

It could also be a completly misreading of code on my side (non XFCE
coder or user, just quick look at the issue). Up to you to decide if
you investigate more, just patch netk-pager.c or insist in "sawfish is
broken".

GSR

- -------------------------------------------------------

- -- 

! 
 Willy Gardiol - willy at gardiol.org
 www.gardiol.org
 +39 3492800983
 Use linux for your freedom.

   "L'altrove è uno specchio in negativo. 
    Il viaggiatore riconosce il poco che è suo, 
    scoprendo il molto che non ha avuto e non avrà"

      Italo Calvino - Le città invisibili

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBRBTDQ9qolN/zUk4RAurUAKCilqhWN0xS/qI7tKFp6/hatkcPyQCgndjs
ZYyDNil1fZ/+7L0Z2NLGIt8=
=uOS+
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: netk-pager.c.patch
Type: text/x-diff
Size: 2177 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20040912/d7ac8005/attachment.patch>