[patch] shortcut editor

[Jean-François Wauthy]

Le jeu 17/06/2004 à 18:40, Olivier a écrit :
> Jean-Francois,
> 
> There is a show stopper with your patch: It doesn't build with gtk+-2.2
> (because of GtkTreeVewSelection at least)
i tried to compile with gtk-2.2 and seems to work fine (perhaps i
screwed my settings to "switch" to gtk-2.2). Plus, GtkTreeSelection i'm
using in the editor is part of gtk-2.2. So i'm lost :)

>  which is the target for xfce
> 4.2, so it really needs to be fixed or I'll have to revert...
> 
> Cheers,
> Olivier.
> 
> On Thu, 2004-06-17 at 08:20, Olivier wrote:
> > Salut Jean-Francois
> > 
> > Ok, commited with a few small changes. I changed the layout a bit to
> > improve readbility in the treeviews, changed some labels, move the
> > notebooks...
> > 
> > I've also changed the identation of the code as I really don't like Java
> > style indent.
> > 
> > A few remarks:
> > 
> > - The "browse" command button does nothing yet
> > - The dialog displayed when waiting for the user to enter the shortcut
> > needs a bit more work, like an icon or something;
> > - I really think the code should be splitted in several sources, it's
> > hard to browse a 3800+ lines source file :)
> > - Please use the same indentation as I use for xfwm4,
> > 
> > Thanks,
> > Olivier
> > 
> > On Wed, 2004-06-16 at 22:42, Jean-François Wauthy wrote:
> > > I think the patch i wrote to add shortcut editing in xfwm4 is in final
> > > stade, so i send to patch. What do you think about Olivier ?
-- 
Jean-François Wauthy <pollux at castor.be>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message num?riquement sign?e.
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20040618/224ffb23/attachment.pgp>