[Xfce4-commits] CVS: xfce4/xfdesktop/settings backdrop_settings.c, 1.84, 1.85 backdrop-icon.h, 1.7, NONE menu.png, 1.1, NONE

[Benedikt Meurer]

Brian J. Tarricone wrote:
>>>      mcs_plugin->caption = g_strdup (_("Desktop"));
>>>      mcs_plugin->run_dialog = run_dialog;
>>>  
>>> -    mcs_plugin->icon = gdk_pixbuf_new_from_inline(-1, 
>>> backdrop_icon_data,
>>> -            FALSE, NULL);
>>> +    mcs_plugin->icon = xfce_themed_icon_load("xfce4-backdrop", 32);
>>
>>
>> Don't you think its better to have all mcs icons at the same size? The 
>> desktop plugin is the only one to use a 32x32 icon, which looks kinda 
>> odd. We should either change all other plugins to use 32x32 or the 
>> desktop plugin should use the 48x48 size as well.
> 
> 
> gah, fine, i'll change it.  a while ago jasper noted that some of the 
> mcs plugins used 32x32 icons, and some used 48x48, and we decided the 
> 32x32 icons looked better, so that's what i was going by.  whatever.

Well, no problem, as long as all icons are equal in size, but we should 
discuss this when jasper and olivier are back.

>    -brian

Benedikt

-- 
NetBSD Operating system:                       http://www.NetBSD.org/
pkgsrc "Work in progress":                  http://pkgsrc-wip.sf.net/
XFce desktop environment:                        http://www.xfce.org/
German Unix-AG Association:                   http://www.unix-ag.org/
os-cillation:                             http://www.os-cillation.de/

OpenPGP Key: http://www.home.unix-ag.org/bmeurer/#gpg