convenience code for choosing command and icon in xfce4-panel

[Danny Milosavljevic]

Hi,

Am Mon, den 19.01.2004 schrieb Jasper Huijsmans um 11:35:
> Danny Milosavljevic wrote:
> 
> >Am Son, den 18.01.2004 schrieb Jasper Huijsmans um 15:36:
> >  
> >
> >>FYI,
> >>
> >>I just split out the code from panel/item_dialog.c to choose a command
> >>(using the completion combo if available) and to choose an icon, so it
> >>can be used by others (plugin writers).
> >>
> >>Look at item_dialog.h and item_dialog.c to see how it works. The
> >>mailcheck plugin and, obviously, the item dialog already use it.
> >>    
> >>
> >
> >In an attempt to see what I did wrong, I checked the mailcheck code for
> >destroy_command_option and found that it is not called at all O_o
> >
> >Why is that ? 
> >
> >  
> >
> Hmm, yeah, the code calls destroy_command_options when the base widget 
> is destroyed. Perhaps that function should not be public ...

I seee.... so I destroy it and you destroy it too and *boom* :)

Yup, I'd make the function private :)

cheers,
    Danny