patch for xfce4-panel

[Jasper Huijsmans]

Op vr 09-01-2004, om 19:21 schreef edscott wilson garcia:
> I'll answer this one first since it is shorter.
> 
> On Fri, 2004-01-09 at 05:52, Jasper Huijsmans wrote:
> > Op vr 09-01-2004, om 12:14 schreef Jasper Huijsmans:
> > ...
> > > First, the compilation should check for the combo module, not just
> > > libdbh. If there isn't a .pc file now, we have to make one.
> > > 
> > 
> > No, I guess this is wrong. It is loaded dynamically, so we only need the
> > dbh dependency for the dbh header file. This kinda defeats the purpose
> > of the dynamic loading though ....
> > 
> 
> Not really. To link the module-loading code, you need dbh. Otherwise
> compilation will fail. So you cannot test whether the module fails to
> load if dbh is not installed. Ergo, do not even try to test for the
> module if dbh is not installed. You will notice that dbh is set as an
> optional check and compilation will not fail if dbh is not installed.
> 
> > Could we get the libdbh dependency entirely into the module?
> 
> The xfce4-modules will fail to compile without dbh. No problem there.
> But if we have a user who does not have dbh (hence no xfce4-modules nor
> xffm nor xfcalendar either), we still want to have a working panel. So
> in the case no dbh is found, compile the panel without use of
> libxfce_combo.
> 

I'm wondering, would loading of the combo_module fail if the panel was
not linked with dbh or are the 'dependencies' of the module loaded as
well? I'm thinking it wil fail ...

	Jasper