[Xfce4-commits] CVS: xfce4/xfdesktop/src menu-dentry.c,1.7,1.8

[Brian J. Tarricone]

Jasper Huijsmans wrote:

>Op do 26-02-2004, om 04:14 schreef Brian Tarricone:
>  
>
>>Update of /var/cvs/xfce/xfce4/xfdesktop/src
>>In directory dbguin.lunar-linux.org:/tmp/cvs-serv5021
>>
>>Modified Files:
>>	menu-dentry.c 
>>Log Message:
>>add a 'blacklist' of gnome/kde control panels that don't have an 
>>OnlyShowIn= property
>>
>>
>>Index: menu-dentry.c
>>===================================================================
>>RCS file: /var/cvs/xfce/xfce4/xfdesktop/src/menu-dentry.c,v
>>retrieving revision 1.7
>>retrieving revision 1.8
>>diff -u -d -r1.7 -r1.8
>>--- menu-dentry.c	25 Feb 2004 08:11:02 -0000	1.7
>>+++ menu-dentry.c	26 Feb 2004 03:14:42 -0000	1.8
>>@@ -66,6 +66,18 @@
>> 	"/usr/share/gnome/apps/",
>> };
>> 
>>+/* these .desktop files _should_ have an OnlyShowIn key, but don't.  i'm going
>>+ * to match by the Exec field. */
>>+static char *blacklist[] = {
>>+	"gnome-control-center",
>>+	"kmenuedit",
>>+	"kcmshell",
>>+	"kcontrol",
>>+	"kpersonalizer",
>>+	"kappfinder",
>>+	NULL
>>+};
>>+	
>>    
>>
>
>Hmm, I'm not sure this is a good idea. If you are using gnome or kde
>apps, these programs could be useful, couldn't they?
>

i'm not terribly thrilled with it either. but these guys seem to be 
generally useless in xfce.  the items that show up without the blacklist 
are things like kde's menu editor (oddly, there are 3 of them), and some 
very desktop-centric config panels.  the only one that i can see an 
argument for leaving alone is gnome-control-center, and even then, i 
don't see how it's terribly useful.  the point here is that these are 
all _desktop_ configuration apps, and really don't have much (if 
anything) to do with applications.  afaict, anyway.

if you still think it's a bad idea, i'll take it out, but i _really_ 
don't like having gnome- and kde-centric stuff in my settings menu.

    -brian