[PATCH] Xfce 4.2 rc 1 & 2 panel not starting up

[Jasper Huijsmans]

Ciao Michele,

Thank you very much! I have committed it to CVS.

	Jasper


On Tue, Dec 14, 2004 at 12:27:10PM +0100, Michele Baldessari wrote:
> [resend: messed up first time. sorry if a duplicate mail shows up]
> 
> Hi there,
> 
> I finally took some time to investigate why my xfce4-panel (everything
> else is fine) never started up on my debian unstable ppc laptop (it 
> works fine on my x86 workstation, same distro). This happened with
> rc1,rc2 and a couple of cvs snapshots in between.
> 
> It basically gets stuck in panel/xfce_support.c +211 write_backup_file(), due
> to a wrong size comparison (gcc 3.3.5 spews "warning: comparison is always
> true due to limited range of data type" on those lines). getc returns an int 
> and EOF is sizeof(int).
> 
> The attached patch fixes the startup problem here. While I was at it, I
> alse fixed the other comparisons I found.
> 
> Hope it sounds ok. Obviously casting EOF to (char)EOF and not changing
> the type for 'c' works as well. (but is uglier methinks)
> 
> See http://www.federated.com/~jim/arm/charhell.html for more
> details.
> 
> Michele Baldessari
>