icon theme bugs

[Brian J. Tarricone]

Jasper Huijsmans wrote:

> Hey Brian ;-)
>
> First a small problem. Can it be that xfce_icontheme does not look in 
> ~/.icons? Or perhaps it doesn't merge contents of different theme 
> directories for the same theme?

it might not be.  i thought xfce_resource_lookup_all() would retur it, 
but now that you mention it, probably not.

> Anyway, on to the big one: changing the icon theme crashes the panel 
> and xfce-mcs-manager. It did crash xfdesktop as well, but when I ran 
> all three in gdb, xfdesktop remained running.

hmm, i'm not seeing this, at least for the panel or xfdesktop.  i 
haven't restarted mcs yet.  i'll have to look at it tonight.

> I didn't immediately see a solution. Here are the backtraces:
>
> * xfce-mcs-manager:
>
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 16384 (LWP 17024)]
> 0x4057586d in g_hash_table_destroy () from /usr/lib/libglib-2.0.so.0
> (gdb) bt
> #0  0x4057586d in g_hash_table_destroy () from /usr/lib/libglib-2.0.so.0
> #1  0x4023f808 in theme_dir_destroy () from /usr/lib/libgtk-x11-2.0.so.0
> #2  0x4057cb48 in g_list_foreach () from /usr/lib/libglib-2.0.so.0
> #3  0x4023f79a in theme_destroy () from /usr/lib/libgtk-x11-2.0.so.0
> #4  0x4057cb48 in g_list_foreach () from /usr/lib/libglib-2.0.so.0
> #5  0x4023e003 in blow_themes () from /usr/lib/libgtk-x11-2.0.so.0
> #6  0x4023df45 in do_theme_change () from /usr/lib/libgtk-x11-2.0.so.0
> #7  0x4023da79 in update_current_theme () from 
> /usr/lib/libgtk-x11-2.0.so.0
> #8  0x4053b37d in g_cclosure_marshal_VOID__PARAM ()
>    from /usr/lib/libgobject-2.0.so.0

that's weird.  blow_themes() is from GtkIconTheme, not XfceIconTheme.

> * xfce4-panel
>
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 16384 (LWP 17185)]
> icon_list_free (icon_list=0x80bf384) at xfce-icontheme.c:144
> 144                     g_free(icon->path);
> (gdb) bt
> #0  icon_list_free (icon_list=0x80bf384) at xfce-icontheme.c:144
> #1  0x4055329d in g_hash_table_foreach () from /usr/lib/libglib-2.0.so.0
> #2  0x40052e65 in invalidate_theme (icon_theme=0x0) at 
> xfce-icontheme.c:285
> #3  0x400534fc in check_icon_theme (icon_theme=0x80b8f70)
>     at xfce-icontheme.c:481
> #4  0x400537d1 in xfce_icon_theme_lookup (icon_theme=0x80b8f70,
>     icon_name=0x40c04925 "mail", icon_size=30) at xfce-icontheme.c:550
> #5  0x4002ade5 in xfce_themed_icon_lookup (name=0x0, size=0) at 
> icons.c:163
> #6  0x08053845 in themed_pixbuf_from_name_list (namelist=0x40c05b94, 
> size=30)
>     at icons.c:90
> #7  0x40c02b9c in get_mail_pixbuf () at mailcheck.c:107
> #8  0x40c02c1c in reset_mailcheck_icons (mc=0x8191088) at mailcheck.c:131
> #9  0x40c03b0b in mailcheck_set_theme (control=0x0, theme=0x80608b8 
> "Nuvola")
>     at mailcheck.c:651
> #10 0x080523cc in control_set_theme (control=0x1, theme=0x0) at 
> controls.c:1135
> #11 0x08053317 in groups_set_theme (theme=0x80608b8 "Nuvola") at 
> groups.c:435
> #12 0x08057e2b in icontheme_cb (icontheme=0x80f7ea8) at mcs_client.c:159
> #13 0x4051f9d6 in g_cclosure_marshal_VOID__VOID ()
>    from /usr/lib/libgobject-2.0.so.0

ok, this is actually XfceIconTheme.  i'm not really sure why it's 
crashing - i guess the only thing that could crash there would be if 
icon is NULL (checking that value in gdb would be helpful).  again, i'll 
look at it this evening.

    -brian