[Xfce4-commits] CVS: xfce4/xffm/libs recent.c,1.16,1.17

[Benedikt Meurer]

edscott wrote:
> El mar, 24-08-2004 a las 08:10, Benedikt Meurer escribió:
> 
>>Edscott Wilson Garcia wrote:
>>
>>>Update of /var/cvs/xfce/xfce4/xffm/libs
>>>In directory dbguin.lunar-linux.org:/tmp/cvs-serv4937
>>>
>>>Modified Files:
>>>	recent.c 
>>>Log Message:
>>>remove C99 code (is there a way to tell gcc not to accept C99?) 
>>
>>cc -std=c89
>>cc -ansi
>>cc -std=iso9899:1990
> 
> 
> Thanks Benny, although c99 code still get through. Nonetheless, I can
> catch those c99 declaration-after-statement errors if I use
> export=CFLAGS="-Wall -pedantic-errors" before autogen.sh. 
> 
> But the headers from libxfce4util make compilation fail (I can remove
> extra commas and semicolons and commit if OK with you,

No, please leave them, else editors indentation logic gets confused.

> but I don't know
> what the c99 "anonymous variadic macros" are all about): 

Thats because you compiled your glib with c99 enabled and so glib has 
set the G_HAVE_ISO_VARARGS define, which indicates that the compiler 
understands C99 style variable argument lists for macros. Rule of thumb: 
Ignore it :)

regards,
Benedikt