xfce-mcs-manager: patch (collation)

Brian J. Tarricone bjt23 at cornell.edu
Fri Aug 6 00:48:45 CEST 2004


not sure what the point of this is....  why would you want to compare 
the plugin caption rather than the plugin name?  the latter is 
guaranteed to be unique, while the former, SHOULD be, but isn't 
necessarily.  using the plugin name kinda obviates the need for 
strcoll(), since it's always going to be in uninternationalised straight 
ascii.

    -brian

Danny Milosavljevic wrote:

>Hi,
>
>here I go, nitpicking again..
>
>patch attached ;)
>
>cheers,
>   Danny
>
>  
>
>------------------------------------------------------------------------
>
>--- xfce-mcs-manager/xfce-mcs-dialog.c.ORIG	2004-08-06 00:16:03.308690144 +0200
>+++ xfce-mcs-manager/xfce-mcs-dialog.c	2004-08-06 00:17:27.376909832 +0200
>@@ -76,10 +76,10 @@
> 
> static int plugincmp (McsPlugin *a, McsPlugin *b)
> {
>-    if (!a || !b || !(a->plugin_name) || !(b->plugin_name))
>+    if (!a || !b || !(a->caption) || !(b->caption))
>         return -1;
>     
>-    return strcmp(a->plugin_name, b->plugin_name);
>+    return strcoll(a->caption, b->caption);
> }
> 
> static GtkWidget *
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Xfce4-dev mailing list
>Xfce4-dev at xfce.org
>http://lunar-linux.org/mailman/listinfo/xfce4-dev
>



More information about the Xfce4-dev mailing list