[Xfce4-commits] CVS: xfce4/xfwm4-themes/themes/gorilla Makefile.am, 1.3, 1.4 Makefile.in, 1.7, 1.8

[Olivier Fourdan]

End of thread. I've now reverted to install.

Cheers,
Olivier.

On Tue, 2004-04-27 at 04:13, Biju Chacko wrote:
> On Sat, 24 Apr 2004 12:15:19 +0200
> Benedikt Meurer <benedikt.meurer at unix-ag.uni-siegen.de> wrote:
> 
> > Olivier,
> > 
> > >  install-themeDATA:
> > > -	rm -Rf $(DESTDIR)$(themedir); \
> > > -	$(mkinstalldirs) $(DESTDIR)$(themedir); \
> > > -	tar cf - $(theme_DATA) | ( cd $(DESTDIR)$(themedir) ; tar xf -
> > > ); \-	if test `id -u` = "0"; then \
> > > -	    chown root:root $(DESTDIR)$(themedir); \
> > > -	    chown root:root $(DESTDIR)$(themedir)/*; \
> > > -	fi; \
> > > -	chmod 755 $(DESTDIR)$(themedir); \
> > > -	chmod 644 $(DESTDIR)$(themedir)/*
> > > +	rm -Rf $(DESTDIR)$(themedir); 					\
> > > +	$(mkinstalldirs) $(DESTDIR)$(themedir); 			\
> > > +	tar cf - $(theme_DATA) | (cd $(DESTDIR)$(themedir) ; tar xf -
> > > --no-same-owner)
> > 
> > Please revert this change, since it breaks w/ nearly every system,
> > except those where tar is gtar. So, please, either use gtar or don't
> > use GNU tar options.
> > 
> > BTW: How about the POSIX.2 way of doing things?
> > 
> > 	pax -rw $(theme_DATA) $(DESTDIR)$(themedir)
> > 
> > This is simpler, tho some systems still don't ship pax. But I think
> > every system that Xfce runs on is somewhat POSIX.2 compliant.
> 
> Ummm ... perhaps this is a silly idea, but why not distribute
> xfwm4 themes as tarballs? xfwm4 (or rather the mcs plugin) would untar
> and ungzip the tarball at runtime and apply the theme.
> 
> Using install would not have much more overhead than pax or tar in this
> case and themes would take up less space on the disk too.
> 
> My Rs 0.90 (2c),
> 
> -- b
-- 
 - Olivier Fourdan - fourdan at xfce.org - http://www.xfce.org -