libxfce4util broken(was: Xffm creates bad files)

[edscott wilson garcia]

El mié, 31-03-2004 a las 12:42, Benedikt Meurer escribió:

> 
> This does not seem to be a sane solution. An application should exit with an 
> error message if it is unable to determine the users home directory. 
> Everything else is wrong and IMHO dangerous.

To exit is a bit too drastic for me. Not being able to determine the
home directory should not be dangerous. As you suggested some days ago,
you cannot take away the wheels of a car so that drivers will not crash.
The application should know what to do if it gets NULL for a home
directory, otherwise, IMHO, it's a crappy application.

> 
> > That's more the way gtk and glib work and it makes for easier coding.
> > just my $0.02. If you want me to fix the library I'll proceed that way.
> 
> I see two possibilites: Either we fix xfce_get_{user,home}file_r, or we remove 
> it from libxfce4util.

Fixing sounds like the best option. If it is removed, then the following
files must be fixed:

$fgr -r -a -e xfce_get_ -I -t any -f *c 
/usr/home/common/CVS/lunar/HEAD/xfce4/libxfce4util/libxfce4util/i18n.c
/usr/home/common/CVS/lunar/HEAD/xfce4/libxfce4util/libxfce4util/xfce-miscutils.c
/usr/home/common/CVS/lunar/HEAD/xfce4/libxfce4util/libxfce4util/xfce-resource.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfcalendar/plugin/xfcalendar_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfcalendar/src/callbacks.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfcalendar/src/main.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-mcs-manager/xfce-mcs-manager/xfce-mcs-manager.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-mcs-plugins/plugins/display_plugin/display_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-mcs-plugins/plugins/keyboard_plugin/keyboard_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-mcs-plugins/plugins/mouse_plugin/mouse_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-mcs-plugins/plugins/ui_plugin/ui_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-utils/xfce4-about/info.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-utils/xfrun/xfrun.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce-utils/xftaskbar/plugin/xftaskbar_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4/panel/xfce_support.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4/settings/xfce_settings_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-iconbox/src/main.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-mixer/settings/sound.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-mixer/src/xfce-mixer-profiles.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-mixer/src/xfce-mixer-window.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-panel/panel/xfce_support.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-panel/panel/xfcombo.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-panel/settings/xfce_settings_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-panel-new/panel/xfce_support.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-panel-new/settings/xfce_settings_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-session/settings/session.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-session/xfce4-session/main.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-session/xfce4-session/manager.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-session/xfce4-session/splash-screen.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfce4-session/xfce4-session/startup.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfdesktop/menueditor/menueditor.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfdesktop/settings/backdrop-mgr.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfdesktop/settings/backdrop_settings.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfdesktop/settings/settings_common.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfdesktop/src/menu-file.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfprint/lib/xfprinterlist.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfprint/lib/xfprintsettings.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfprint/xfprint/printdlg.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfwm4/mcs-plugin/plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfwm4/mcs-plugin/xfwm4_plugin.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfwm4/src/main.c
/usr/home/common/CVS/lunar/HEAD/xfce4/xfwm4/src/settings.c


quite a few.

regards,

Edscott


> 
> Benedikt