Worspaces and Margins dialog in CVS

[Olivier Fourdan]

Hi Jasper,

It needs rework, I mean, it's not inline with the rest of the code.

1) MCS value names are prefixed with "Xfwm/" in xfwm. 
2) set_workspace_names() has nothing to do in settings.c
3) I don't think it's the role of the WM to set workspace names btw
4) I don't use gdk_property_change() but X11 native routine (same goes
for gdk_x11_xatom_to_atom, etc.) These are pure X11 and I prefer to use
Xlib routines for those.
5) xfwm4 has its own static variables for root, display, etc. It's
better to stick with the ones from xfwm4 for now, so when/if I ever
implement multiple screen management from 1 single xfwm4 instance, that
will make my life easier.
6) It seems to me your patch goes further than just moving the MCS
plugin from xfdesktop to xfwm4. I really want to keep bloat out of
xfwm4, or at least keep bloat under control ;)

Cheers,
Olivier. 

 
On Wed, 2003-10-08 at 10:34, Jasper Huijsmans wrote:
> FYI,
> 
> I just committed the Workspaces and Margins dialog to CVS. You need to
> update both xfdesktop and xfwm4 to make use of it. I also updated the
> documentation to reflect the changes.
> 
> The changes were made to the HEAD branch only. So, it will not be part
> of the 4.0.x bugfix releases. It contains a few string changes, but
> there's no need to rush out translation updates, since it won't be part
> of 4.0.1.
> 
> Note on branches:
> 
> for HEAD: cvs co xfce-devel xfce4-extras
> 
> for xfce_4_0: cvs co -r xfce_4_0 xfce-devel xfce4-extras
> 
> Enjoy,
> 	Jasper
> 
> PS
> Olivier, I had tp remove references to default-4.0 from configure.ac and
> themes/Makefile.am to make it build, since it was an empty directory.
> Perhaps you forgot to do a cvs add ?
> 
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
-- 
Olivier Fourdan - fourdan at xfce.org
   
   Interoperability is the keyword, uniformity is a dead end. 
   http://www.xfce.org