Problems with NET_WM_STATE_FULLSCREEN

[Olivier Fourdan]

Hi,

Hehehe, I love problem reports that come with patches :)

I'll apply them to both HEAD and 4_0 branch (as soon as we get CVS ready
on the new repository) so we can see if there is any side effect with
other apps (the only way to tell is to try IMO)

Thanks for taking time to prepare patches,

Cheers,
Olivier.

On Sat, 2003-10-04 at 12:23, Arwed von Merkatz wrote:
> Hi,
> 
> i found two problems with the handling of NET_WM_STATE_FULLSCREEN
> windows in xfwm4 4.0.0, both exposed by gst-player (www.gstreamer.net).
> 
> 1. when going fullscreen, gst-player relies on the
> NET_WM_STATE_FULLSCREEN flag being set when it receives a configure
> event to determine whether it should show its menu bar or not. XFwm4
> sets the state after sending the configure event, so gst-players menu
> bar is still shown in fullscreen mode. The attached set-state.patch
> fixes this, i don't think that could lead to negative side effects (i
> haven't noticed any :)
> 
> 2. when starting to play a video in fullscreen mode, gst-player creates
> a new xvideo window and reparents that into the existing window. Doing
> this it requests a minimum size for the window and expects to get the
> full screen size allocated (it doesn't know about the size of the full
> screen, so it can't request it). The attached ignore-request-size.patch
> fixes this by ignoring the requested size for windows that have the
> FULLSCREEN flag set, allocating them the whole screen size. I used the
> MyDisplayFullWidth and MyDisplayFullHeight functions there, which works
> fine here, but do those work for xinerama setups?
-- 
Olivier Fourdan - fourdan at xfce.org
   
   Interoperability is the keyword, uniformity is a dead end. 
   http://www.xfce.org