Found a bug in libxfcegui4 (4.0.1) pager code

Jasper Huijsmans jasper at moongroup.com
Fri Nov 14 09:04:31 CET 2003


Op 2003-11-14 07:50:08 schreef Jasper Huijsmans:
> Op 2003-11-13 23:56:22 schreef Tyson Bashore:
>> In XFCE 4.0.1, my vertically-oriented pager on the panel was very  
>> tall.  I investigated this and found the bug.
>> 
>> In libxfcegui4/netk-pager.c, line 279:
>> > screen_aspect =
>> >            (double) netk_screen_get_width (pager->priv->screen) /
>> >            (double) netk_screen_get_height (pager->priv->screen);
>> 
>> The dimensions were swapped.  So, this code should be:
>> > screen_aspect =
>> >            (double) netk_screen_get_height (pager->priv->screen) /
>> >            (double) netk_screen_get_width (pager->priv->screen);
>>
> 
> Hey Tyson,
> 
> Thanks, I will have a look. You are right about the panel. That  
> didn't used to be the case, did it? I haven't used the pager in the  
> panel for a while.
>

This does seem the correct solution. Olivier, is it alright to commit  
this?

	Jasper



More information about the Xfce4-dev mailing list