feature requests to xfwm and xfce4-panel

[Jasper Huijsmans]

On 12 May 2003 19:17:08 +0200
Olivier Fourdan <fourdan at xfce.org> wrote:

> Hi Jasper,
> 
> On Mon, 2003-05-12 at 14:20, Jasper Huijsmans wrote:
> > While we're talking about the panel, with your permission I'd like
> > to make one more change: remove the type option menu from the item
> > properties dialog (which is a bit odd anyway) and have a separate
> > dialog to add an item that lets the user choose from a list of
> > available modules. Current behaviour sucks in more than one way and
> > this may even solve the problem you reported earlier.
> 
> Changing the code with the hope that will fix a bug is not exactly
> what I call "managed" changes :)
> 
> I think it would be better to find the root cause of the problem
> first, and then improve the code...
> 

Normally I would agree, but the way the modules types were handled has
been a bad idea from day one. It is ugly and difficult to maintain code.
I believe the concept of changing module types on the fly is broken.

> > I know we are in feature freeze, but I think it will be a big
> > improvement. So, should I make the required changes?
> 
> That's fine when adding new items, but what about changing an existing
> item ?
> 

You don't. It's a different concept. You simply remove the old item and
add a new one.

Perhaps slightly less efficient in certain cases, but I believe it makes
more sense to present the different modules as separate items.

Did I mention it simplifies the code considerably?

Please try it and tell me what you think ... tomorow (I just read your
mail ;-)

	Jasper