xffm xml mem leaks fixed

edscott wilson garcia edscott at imp.mx
Sat May 10 07:17:00 CEST 2003


El mié, 07-05-2003 a las 13:59, Jasper Huijsmans escribió: 
> On 07 May 2003 13:06:19 -0500
> edscott wilson garcia <edscott at imp.mx> wrote:
> 
> > On Wed, 2003-05-07 at 08:00, Jasper Huijsmans wrote:
> > > Hey Edscott,
> > > 
> > > I just added the appropriate g_free() statements to the xml parsing
> > > in libs/settings.c and libs/icons.c. That's all xml memory
> > > allocation I could find with a quick scan. 
> > 
> > Thanks Jasper! The only other file that does xml parsing is
> > libs/apps.c, when it reads in the panel configuration. I'll try to
> > apply the same fixes whenever I can get my CVS updated.
> > 
> 
> as far as I could see it didn't do any memory allocation.

I gather from the corrections at icon.c that xmlGetProp() allocates heap
memory. There are a couple xmlGetProp() which would require to be freed.
The only problem is that they are inside a recursive function and that
makes it rather difficult to follow. I tried a little bit but came up
with segfaults.

saludos, 

Edscott 


> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
> 




More information about the Xfce4-dev mailing list