libxfcegui4 dialogs

Jasper Huijsmans jasper at moongroup.com
Wed Mar 12 13:55:50 CET 2003


On Wed, 12 Mar 2003 13:07:53 +0100
Benedikt Meurer <Benedikt.Meurer at unix-ag.uni-siegen.de> wrote:

> Hello Jasper,
> 
> I'd like to replace the show_{error,info,warning} functions in
> libxfcegui4 with the following functions:
> 
> 	xfce_err(const gchar *, ...)
> 	xfce_verr(const gchar *, va_list)
> 	xfce_errx(const gchar *, ...)
> 	xfce_verrx(const gchar *, va_list)
> 	xfce_warn(const gchar *, ...)
> 	xfce_vwarn(const gchar *, va_list)
> 	xfce_warnx(const gchar *, ...)
> 	xfce_vwarnx(const gchar *, va_list)
> 	xfce_info(const gchar *, ...)
> 	xfce_vinfo(const gchar *, ...)
> 
> The functions without the trailing 'x' act similar to the perror(3)
> function. This should make error reporting a bit easier.
> 
> Opinions?
> 

Hmm, those are a lot of functions for relatively simple functionality.
What is the problem you are trying to solve or what is the use-case for
these functions?

The way the dialogs are used now is for really simple user feedback. I
haven't encountered the need for something more sophisticated, I think.

If it's only convenience for having to do a g_strdup_printf() before the
dialog I think it's overkill, if it's more sophisticated with error
numbers and such, I think it won't help us much since many of the
error's in xfce4 come from gtk and are encapsulated by a GError *
anyway.

I'm not pricipally against it, it's just that I want to make sure we
keep things as simple as possible. Basically, what I'm saying is I'd
only like to add stuff that solves a problem now, or makes things easier
now, or reduces duplication or something. I don't want to have things
that may be very useful in the future or the equivalent of the Java
class library incorporated with xfce ;-)(ok, so that's a tiny bit over
the top :-))

	Jasper




More information about the Xfce4-dev mailing list