Deadline rc2

[Jasper Huijsmans]

On Fri, 18 Jul 2003 11:25:53 +0200
Benedikt Meurer <Benedikt.Meurer at unix-ag.uni-siegen.de> wrote:

> On Fri, 18, Jul 2003, Jasper Huijsmans wrote:
> 
> > > Hmm, it is probably not worth it, but I just thought of something
> > > to prevent old API plugins from being loaded and then crash the
> > > panel.
> > > 
> > > The problem is that the new API has changed the prototype of one
> > > function, but it doesn't change the symbol name. The API version
> > > is increased, but this is automatically picked up by the plugin
> > > when recompiling (I'll need to think about that after 4.0, it is
> > > too automatic now). Since the symbol name did not change the old
> > > API plugin compiles without error.
> > > 
> > > Now, the 'solution' is to rename that symbol which will make
> > > compiling or at least loading the old module fail, thus preventing
> > > a crash.
> > > 
> > > All modules would need to be updated again though (well a simple
> > > search and replace will do the trick).
> > > 
> > > I didn't think there would be any more third-party plugins, but
> > > that mail yesterday proved me wrong. So, what do you think, is it
> > > worth the trouble?
> > > 
> > 
> > Oh, and I am prepared to do the work to update all modules in our
> > CVS and on xfce-goodies. It is not difficult but it will take some
> > time.
> 
> I'll help, but *after* 4.0 :-)
> 

Well, it was even easier than I thought, attached are three patches for
xfce-devel, xfce4-extras and xfce-goodies. Not included are the
necessary changes in version number and requirement for a panel version
>= 3.99.2.

I've tested it and it works fine. More importantly it does indeed
prevent the old plugin from building correctly.

Considering that it prevents possible crashes, I'd like to request to be
allowed to put it in anyway. It really is a trivial change.

	Jasper
-------------- next part --------------
A non-text attachment was scrubbed...
Name: devel.patch
Type: application/octet-stream
Size: 7432 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20030718/812bbf18/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extras.patch
Type: application/octet-stream
Size: 4890 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20030718/812bbf18/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: goodies.patch
Type: application/octet-stream
Size: 1651 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20030718/812bbf18/attachment-0002.obj>