XFFM Bug (hidden files) (2 bugs in one)

[edscott wilson garcia]

On Thu, 2003-07-10 at 19:55, edscott wilson garcia wrote:
> On Thu, 2003-07-10 at 11:42, Luis Miguel Garcia wrote:
> > Hola Edscott,
> > 
> > it seems I can keep you busy. I'm moving all of my data to another
> > computer so i'm using xffm a lot and founding new bugs.
> > 
> > And now, the report:
> > 
> > I have activated the "Show hidden" option (mostrar ocultos en el xffm
> > from spain) and the hidden files have appeared. That's correct. Now I
> > close xffm and open it newly. Where are my hidden files? Oh my god! The
> > only files in the list are the normal files. No hidden files even when
> > Options / Show hidden IS ACTIVATED.
> > 
> > If I unckech the option and check it newly, it works perfectly, showing
> > my hidden files and directories.
> > 
> > So I think it's a matter of checking the variable at startup too, not
> > to?
> 
> I confirm the bug. It should be easy to fix.

Fixed. Attached is a patch (24hr bug-workaround). BTW, the "subsort by
filetype" was also misbehaving the same way. No wonder I thought
something was cranky about it but I could not figure it out!

> 
> > 
> > Now, the second bug. When I check Options / Show hidden, the right panel
> > of xffm close the opened directories, and opens it newly with the new
> > configuration (showing the hidden files or not), but the left panel
> > doesn't get updated in this moment. It works if I open new directories,
> > but not for the directories already opened.

This bug needs a little more thought and feedback. Since both treeviews
are using the same treemodel, the update is done to both. But I believe
the ability to have different nodes expanded is quite powerful. Default
goto affects only the right treeview, as other options, being it the
main treeview. You will also notice that if you close a folder in the
main treeview, the icon in the secondary treeview will be closed even if
the node is expanded. At the moment I do not know exactly how to
proceed, so I am waiting for multiple feedback and suggestions to define
the behaviour. The dual view of the same treemodel is a new concept
(quite different from nautilus or konqueror) and therefore needs to
follow a different path.


saludos

Edscott

> 
> I get it. The issue is that when the left panel is collapsed it is not
> expanded again. Both treeviews use the same treemodel so they are both
> updated. It's just that it's not expanded. Well, let's get to work
> then... 
> 
> > 
> > edscott, sorry with my poor english but as you know, I'm spanish and I
> > have problems trying to explain me in english. If you don't understand
> > any of this explanations, I can write it in spanish (perhaps we have
> > better understanding).
> 
> Understand perfectly. No hay problema.
> 
> saludos
> 
> Edscott
> 
> > 
> > thanks a lot...
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
-------------- next part --------------
--- /home/CVS/xfce/xfce-devel/xffm/src/treeview.c	Thu Jul 10 21:45:49 2003
+++ /home/CVS/xfce/xfce-devel/xffm/src/treeview.c-0	Thu Jul 10 21:48:48 2003
@@ -395,10 +395,6 @@
 	SET_ROOT_TYPE(en->type);
 	if (tree_details->preferences & IMAGE_PREVIEW) 
 		SET_SHOWS_IMAGES(en->type);
-	if (tree_details->preferences & SHOW_DOT) 
-		SET_SHOWS_HIDDEN(en->type);
-	if (tree_details->preferences & FILETYPE_SUBS) 
-		SET_TYPE_SUBSORT(en->type);
 	en->tag = NULL;
 	tag = g_strdup(my_utf_string(_(root[i].label)));