jens at irs-net.com
Mon Jan 27 19:07:01 CET 2003
On Mon, 2003-01-27 at 18:03, edscott wilson garcia wrote:
> 1- It's a "good thing" to keep variables localized. For example, putting
> wastebackup into the if block means it will not be pushed up to the
> stack if not needed, and the call to g_free can be avoided. This
> eliminates unnecesary code from being executed.
Agreed, but I actally prefer to declare them all at once.
I probably did it because from my experience with perl.
> 3- Do not include a trailing "/" within path variables. Doing so causes
> many bugs and confusion in xftree and should be avoided in xffm. The
> only path that ends with a slash should be the root dir.
I saw you changed:
wastepath = g_strconcat (filepath, "/..Wastebasket/", NULL);
wastepath = g_strconcat (filepath, "/..Wastebasket","/", NULL);
and used later:
1) why not at once -> "/..Wastebasket/", <- ?
2) iirc accepts the new_name function only two arguments?
Jens Luedicke <jens at irs-net.com>
"Never offend people with style when you can offend them with
More information about the Xfce4-dev