All done ! [WAS Re: API addition to libxfce4mcs]

[Olivier Fourdan]

Jasper,

It's all done! All of your suggestions are done, and a bit more :

- remove xfce-mcs-manager, xfce-settings show and plugins from
libxfce4mcs

- create a new package "xfce-mcs-manager" with xfce-mcs-manager,
xfce-settings show and plugins

- move plugin location to $(libdir)/xfce-mcs-manager/plugins

- use gboolean mcs_client_check_manager(Display *dpy, int screen, const
char *manager_command);

- change gtk-theme plugin to ui_plugin (name "ui") to be more consistent
with keyboard and mouse plugins

- add a mcs_client_check_manager to xfce-setting-show so that if the
user did not run the manager before, it'll get started (ie no more "I
get nothing when I type xfce-setting-show")

- Change version of libxfce4mcs to 0.0.3 to reflect those changes.

- update spec files for "xfce-mcs-manager" and "libxfce4mcs" packages so
they can (or should) be built as rpms

- update xfwm4 to reflect these changes

...Now your turn to update xfce4 (at least for the plugin location!) and
the web page :)

PS: I would prefer xfce-panel instead of xfpanel, but I leave the final
decision to you :)

Boumbidoum bidoum bidam...

Cheers,
Olivier.

On Sat, 2003-01-11 at 12:32, Jasper Huijsmans wrote:
> On 11 Jan 2003 11:39:06 +0100
> Olivier Fourdan <fourdan at xfce.org> wrote:
> 
> > Jasper,
> > 
> > I've added a new function (you requested and implemented in xfce4) to
> > mcs-client.h to check and spawn a mcs-manager
> > 
> >  
> >     gboolean mcs_client_check_manager(Display * display, int screen);
> > 
> 
> Great!
> 
> While on the subject of libxfce4mcs, I have some ideas I'd like to hear
> your opinion on:
> 
> How about expanding the channel saving/loading code a bit to take into
> account user and system directories. I mean the functions should take
> only the file name as argument and then for reading look it up in
> ~/.xfce4/<filename> and if not found look at
> ${sysconfdir}/xfce4/<filename> and for writing put it in ~/.xfce4/. That
> would make it simpler to have standard file locations and to install
> default config files.
> 
> Secondly, I think the settings manager should not be part of the
> libxfce4mcs module. It's not part of the library, it's based on it. And
> the plugins should not be in ${libdir}/libxfce4mcs/settings, but rather
> in ${libdir}/xfce-mcs-manager/plugins/.
> 
> Not that it matters much, but I do think it would be nice if we were a
> bit more consistent about file locations (see my previous mail, that
> nobody cared about :).
> 
> Just tell me to go and worry about something else if you think I'm not
> making any sense.
> 
> 	Jasper
-- 
Olivier Fourdan <fourdan at xfce.org>
http://www.xfce.org