Possible crash in netk-util.c

[Olivier Fourdan]

Hey Jasper,

Sure, if that prevents the crash then go, shoot.

A more deep analysis might be required to find the root cause of the
problem, as it shows only with gtk 2.3.0 (which I definitely can't
compile, so there is no chance that I -at least- shall support any time
soon)

Let's not forget that 2.3.x is a devel release, definitely not supported
by stable xfce4.

Cheers,
Olivier.

On Sun, 2003-12-07 at 10:38, Jasper Huijsmans wrote:
> Hey Olivier,
> 
> This crash was reported on the forum. It is with gtk 2.3.0, so I'm not
> sure if it is a bug in lingui.
> 
> http://xfce.lindesign.se/db/viewtopic.php?t=216&start=17
> 
> The code in netk-util.c assumes that XGetWMHints always succeeds. You
> are a better judge of this than I am, but perhaps something like this
> could be added:
> 
> Index: netk-util.c
> ===================================================================
> RCS file: /var/cvs/xfce/xfce4/libxfcegui4/libxfcegui4/netk-util.c,v
> retrieving revision 1.11
> diff -u -r1.11 netk-util.c
> --- netk-util.c 17 Nov 2003 21:46:21 -0000      1.11
> +++ netk-util.c 7 Dec 2003 09:31:50 -0000
> @@ -65,6 +65,10 @@
>      wmhints =
>          XGetWMHints (GDK_WINDOW_XDISPLAY (widget->window),
>                       GDK_WINDOW_XWINDOW (widget->window));
> +    
> +    if (!wmhints && !(wmhints = XAllocWMHints()))
> +       return;
> +    
>      wmhints->flags |= InputHint;
>      wmhints->input = False;
>      XSetWMHints (GDK_WINDOW_XDISPLAY (widget->window),
> 
> 
> 	Jasper
> 
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
-- 
Olivier Fourdan - fourdan at xfce.org
   
   Interoperability is the keyword, uniformity is a dead end. 
   http://www.xfce.org