codeset bugfixes xffm

[Olivier Fourdan]

Hi Edscott,

But that error is deeply nested in xfdiff4

If you look at xfdiff_miscc, lines 880 to 900, you'll see that you treat
the translated message the same way as the filename.

The filename should be converted to UTF8 as it is right now, but not the
localized text (as in no_patch_dir, no_right_path, no_patch etc.)

So the logic behind this code is wrong. Moreover, the code as it is
right now is a bit, well, tricky to say the least :)

I think this should be redone in a cleaner way (read big bunch of
cleanup). 

As a side note, I'm a bit worry about the state of xffm. I've
encountered yet another bug: Under heavy system workload, deleting a
file sometimes doesn't update the treeview. Afterwords,  collapsing the
view crashes xffm...

But hehehe, right now, it's my turn to say good night/good morning ;)

In the mean time, I've updated CVS with my current changes (that fix the
problem with localized strings in xffm at least)

Cheers,
Olivier.

On Wed, 2003-04-09 at 23:04, Olivier Fourdan wrote:
> Hi Edscott,
> 
> 
> On Wed, 2003-04-09 at 21:32, Olivier Fourdan wrote:
> > Hi Edscott,
> > 
> > On Wed, 2003-04-09 at 05:13, edscott wilson garcia wrote:
> > >   I think all the codeset problems you noticed have now been fixed.
> > 
> > Well, no it's not fixed. I'll look into it if I can find any time.
> 
> 
> Ha!! I know!
> 
> You call g_locale_to_utf8() function even on localized messages!
> 
> E.g.: In dummies.c, I read :
> 
> s = g_locale_to_utf8(_("Reading..."), -1, &r_bytes, &w_bytes, NULL);
> 
> Since the translations are already in UTF8, The translation on
> "Reading..." in UTF8
> 
> By calling g_locale_to_utf8(), you transform UTF8 to UTF8 assuming that
> UTF8 is in the locale encoding! SO not surprisingly, you get wrong
> results if the locale is not UTF8...
> 
> Problem, this error is repeated all along the code :(
> 
> Cheers,
-- 
Olivier Fourdan <fourdan at xfce.org>
http://www.xfce.org