xffm updates

edscott wilson garcia edscott at imp.mx
Mon Apr 7 05:20:05 CEST 2003


El dom, 06-04-2003 a las 17:03, Benedikt Meurer escribió:
> On Sun, 06, Apr 2003, Jasper Huijsmans wrote:
> 
> > On Sat, 5 Apr 2003 23:35:22 +0200
> > Benedikt Meurer <Benedikt.Meurer at unix-ag.uni-siegen.de> wrote:
> > 
> > > On Sat, 05, Apr 2003, Benedikt Meurer wrote:
> > > 
> > > > Edscott,
> > > > 
> > > > I've updated some things in xffm:
> > > > 
> > > > 	- use gthread instead of pthread
> > > > 	- reworked the fstab stuff (xffm now recognizes if a filesystem
> > > > 	is
> > > > 	  already mounted). This needs testing on plattforms without
> > > > 	  getmntinfo/getfsstat.
> > > > 	- auto stuff updated
> > > > 	- use xfce_get_{user,home}dir() instead of g_get_home_dir()
> > > > 	- use localtime_r() instead of localtime() if available
> > > > 	- and some other fixes
> > > 
> > > Committed with heavily changed fstab.c (linux code is still
> > > problematic).
> > > 
> > > I'd like everybody to upgrade and test the changes.
> > > 
> > 
> > I think I fixed the linux issue. It seems getmntent() can not be called
> > nested, so I moved the check for mounted filesystems outside the loop
> > for existing mount points and it seems to work for me.
> > 
> > I left in the printf() of mounted systems until more people tested it.
> > Patch follows for those interested. CVS has been updated already.
> 
> Really nice. One thing left: I think we should prefer getfsent over getmntent
> for the fstab stuff. It seems atleast some glibc installations have getfsent.
> Opinions?

Probably should use the function which is most common in different
platforms, to keep the code easier to maintain.

Edscott

> 
> > 	Jasper
> 
> regards,
> Benedikt
> 
> -- 
> Those who do not understand Unix are condemned to reinvent it, poorly.
>     -- Henry Spencer
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
> 





More information about the Xfce4-dev mailing list