[Xfce4-commits] [xfce/libxfce4ui] 01/01: removed some superfluous 'gtk_widget_show()' in order to be consistent with GTK creation methods.

noreply at xfce.org noreply at xfce.org
Thu Mar 26 22:20:49 CET 2020


This is an automated email from the git hooks/post-receive script.

a   l   e   x       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/libxfce4ui.

commit 88d447cab52a52840d8e310138e9c1a96516b86c
Author: Alexander Schwinn <alexxcons at xfce.org>
Date:   Thu Mar 26 22:19:37 2020 +0100

    removed some superfluous 'gtk_widget_show()' in order to be consistent
    with GTK creation methods.
---
 libxfce4ui/xfce-gtk-extensions.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libxfce4ui/xfce-gtk-extensions.c b/libxfce4ui/xfce-gtk-extensions.c
index 83a4f33..0bcf128 100644
--- a/libxfce4ui/xfce-gtk-extensions.c
+++ b/libxfce4ui/xfce-gtk-extensions.c
@@ -79,7 +79,6 @@ xfce_gtk_menu_item_fill_base (GtkWidget    *item,
     g_signal_connect_swapped (G_OBJECT (item), "activate", callback, callback_param);
   if (menu_to_append_item != NULL)
     gtk_menu_shell_append (menu_to_append_item, item);
-  gtk_widget_show (item);
 }
 
 
@@ -371,8 +370,6 @@ xfce_gtk_tool_button_new_from_action_entry (const XfceGtkActionEntry *action_ent
   tool_item = gtk_tool_button_new (image, action_entry->menu_item_label_text);
   g_signal_connect_swapped (G_OBJECT (tool_item), "clicked", action_entry->callback, callback_param);
   gtk_widget_set_tooltip_text (GTK_WIDGET (tool_item), action_entry->menu_item_tooltip_text);
-  gtk_widget_show (GTK_WIDGET (tool_item));
-  gtk_widget_show (image);
   gtk_toolbar_insert (toolbar_to_append_item, tool_item, -1);
   return GTK_WIDGET (tool_item);
 }
@@ -396,7 +393,6 @@ xfce_gtk_menu_append_seperator (GtkMenuShell *menu)
 
   item = gtk_separator_menu_item_new ();
   gtk_menu_shell_append (menu, item);
-  gtk_widget_show (item);
 }
 
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list