[Xfce4-commits] [xfce/libxfce4ui] 09/28: xfce-dialogs: Drop default window titles

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   c   h   o   s   i       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/libxfce4ui.

commit 4511d44c533720c18fec121de6c233d599ba7eae
Author: Simon Steinbeiss <simon.steinbeiss at elfenbeinturm.at>
Date:   Fri Jan 3 23:57:56 2020 +0100

    xfce-dialogs: Drop default window titles
    
    With client side decorations this looks weird anyway plus the titles are
    not very telling. If the creator of a dialog wants to set a meaningful
    title, it will still be displayed.
    Another use-case for window titles would be the alt-tab dialog or any
    other type of window list, but GtkMessageDialogs don't show up there
    anyway.
---
 libxfce4ui/xfce-dialogs.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/libxfce4ui/xfce-dialogs.c b/libxfce4ui/xfce-dialogs.c
index b5b1ead..65b42b8 100644
--- a/libxfce4ui/xfce-dialogs.c
+++ b/libxfce4ui/xfce-dialogs.c
@@ -267,15 +267,13 @@ xfce_dialog_show_help_with_version (GtkWindow   *parent,
     primary = g_strdup (_("Do you want to read the manual online?"));
 
   dialog = xfce_message_dialog_new (parent,
-                                    _("Online Documentation"),
+                                    NULL,
                                     "dialog-question",
                                     primary,
                                     _("You will be redirected to the documentation website "
                                       "where the help pages are maintained and translated."),
-                                    "gtk-cancel",
+                                    _("_Cancel"),
                                     GTK_RESPONSE_NO,
-                                    XFCE_BUTTON_TYPE_MIXED,
-                                    "help-browser",
                                     _("_Read Online"),
                                     GTK_RESPONSE_YES,
                                     NULL);
@@ -331,7 +329,7 @@ xfce_dialog_show_info (GtkWindow   *parent,
   primary_text = g_strdup_vprintf (primary_format, args);
   va_end (args);
 
-  xfce_message_dialog (parent, _("Information"),
+  xfce_message_dialog (parent, NULL,
                        "dialog-information",
                        primary_text, secondary_text,
                        XFCE_BUTTON_TYPE_MIXED, "window-close-symbolic", _("Close"),
@@ -366,7 +364,7 @@ xfce_dialog_show_warning (GtkWindow   *parent,
   primary_text = g_strdup_vprintf (primary_format, args);
   va_end (args);
 
-  xfce_message_dialog (parent, _("Warning"),
+  xfce_message_dialog (parent, NULL,
                        "dialog-warning",
                        primary_text, secondary_text,
                        XFCE_BUTTON_TYPE_MIXED, "window-close-symbolic", _("Close"),
@@ -402,7 +400,7 @@ xfce_dialog_show_error (GtkWindow    *parent,
   primary_text = g_strdup_vprintf (primary_format, args);
   va_end (args);
 
-  xfce_message_dialog (parent, _("Error"),
+  xfce_message_dialog (parent, NULL,
                        "dialog-error",
                        primary_text, error ? error->message : NULL,
                        XFCE_BUTTON_TYPE_MIXED, "window-close-symbolic", _("Close"),
@@ -461,7 +459,7 @@ xfce_dialog_confirm (GtkWindow   *parent,
       no_stock_id = _("Cancel");
     }
 
-  response_id = xfce_message_dialog (parent, _("Question"),
+  response_id = xfce_message_dialog (parent, NULL,
                                      "dialog-question",
                                      primary_text,
                                      secondary_text,

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.