[Xfce4-commits] [xfce/thunar] 01/01: Do not check G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE anymore (Bug #15367)

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

a   n   d   r   e       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       x   f   c   e   -   4   .   1   4   
   in repository xfce/thunar.

commit 46f4f0f0fa1edb3535aacdef76017ee41eb55047
Author: Andre Miranda <andreldm at xfce.org>
Date:   Mon May 27 22:15:49 2019 -0300

    Do not check G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE anymore (Bug #15367)
---
 thunar/thunar-transfer-job.c | 25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/thunar/thunar-transfer-job.c b/thunar/thunar-transfer-job.c
index 47fa3bf..cfa932a 100644
--- a/thunar/thunar-transfer-job.c
+++ b/thunar/thunar-transfer-job.c
@@ -827,26 +827,11 @@ thunar_transfer_job_verify_destination (ThunarTransferJob  *transfer_job,
         }
     }
 
-  if (succeed)
-    {
-      dest_info = g_file_query_info (dest, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE, 0,
-                                     exo_job_get_cancellable (EXO_JOB (transfer_job)),
-                                     NULL);
-
-      if (dest_info != NULL)
-        {
-          if (!g_file_info_get_attribute_boolean (dest_info, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE))
-            {
-              g_set_error (error, G_IO_ERROR, G_IO_ERROR_READ_ONLY,
-                           _("Error while copying to \"%s\": The destination is read-only"),
-                           dest_name);
-
-              succeed = FALSE;
-            }
-
-          g_object_unref (G_OBJECT (dest_info));
-        }
-    }
+  /* We used to check G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE here,
+   * but it's not completely reliable, especially on remote file systems.
+   * The downside is that operations on read-only files fail with a generic
+   * error message.
+   * More details: https://bugzilla.xfce.org/show_bug.cgi?id=15367#c16 */
 
   g_object_unref (filesystem_info);
   g_object_unref (G_OBJECT (dest));

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.