[Xfce4-commits] [xfce/xfwm4] 06/06: compositor: Remove glXWaitGL() call

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   l   i   v   i   e   r       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfwm4.

commit 89f3ab5db72226aac6cec1c6adf4f03ce16b010e
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Thu May 23 21:41:36 2019 +0200

    compositor: Remove glXWaitGL() call
    
    Bug: 15453
    
    This was added to avoid flickering with NVIDIA proprietary/closed source
    driver (commit f75652e - "Add back the glXWaitGL to compositor sync
    code"), but that translates as a busy wait, hence increasing CPU usage
    of xfwm4 with the NVIDIA proprietary/closed source driver.
    
    By setting “__GL_MaxFramesAllowed” to 1, that busy wait should not be
    needed anymore.
    
    As a bonus, it also improve responsiveness with with the open source
    drivers.
    
    Taken from similar patch posted by NVIDIA developer for kwin:
    https://phabricator.kde.org/D19867
    
    Signed-off-by: Olivier Fourdan <fourdan at xfce.org>
---
 src/compositor.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/compositor.c b/src/compositor.c
index dcbef14..939ee97 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -1662,8 +1662,6 @@ redraw_glx_texture (ScreenInfo *screen_info, XserverRegion region, gushort buffe
 
     glPopMatrix();
 
-    glXWaitGL();
-
     check_gl_error();
 }
 #endif /* HAVE_EPOXY */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.