[Xfce4-commits] [xfce/xfwm4] 10/11: netwm: Do not skip standalone dialogs

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   l   i   v   i   e   r       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfwm4.

commit 1c2e8f54cd68db0ff870cb60beda26ed93431290
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Wed May 15 22:38:42 2019 +0200

    netwm: Do not skip standalone dialogs
    
    Bug: 15400
    
    Dialog windows which have no parent should not be skipped from taskbar.
    
    Signed-off-by: Olivier Fourdan <fourdan at xfce.org>
---
 src/netwm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/netwm.c b/src/netwm.c
index 59567d3..62ce44b 100644
--- a/src/netwm.c
+++ b/src/netwm.c
@@ -1289,13 +1289,16 @@ clientWindowType (Client * c)
             c->type = WINDOW_DIALOG;
             c->initial_layer = WIN_LAYER_NORMAL;
             /* Treat DIALOG without transient_for set as transient for group */
-            FLAG_SET (c->flags, CLIENT_FLAG_SKIP_TASKBAR);
             if ((c->transient_for == None) || (!clientGetTransient (c)))
             {
                 TRACE ("invalid transient 0x%lx specified for dialog window 0x%lx (%s)",
                        c->transient_for, c->window, c->name);
                 c->transient_for = c->screen_info->xroot;
             }
+            else
+            {
+                FLAG_SET (c->flags, CLIENT_FLAG_SKIP_TASKBAR);
+            }
         }
         else if (c->type_atom == display_info->atoms[NET_WM_WINDOW_TYPE_NORMAL])
         {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.