[Xfce4-commits] [xfce/xfdesktop] 01/01: Stop ongoing drag/selection if middle/right mouse button is pressed (Bug #14180)

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

a   n   d   r   e       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfdesktop.

commit 57ac5cb30a1e01bd506799a088940ca2e0f13ca0
Author: Theo Linkspfeifer <lastonestanding at tutanota.com>
Date:   Sat Mar 30 15:30:42 2019 -0300

    Stop ongoing drag/selection if middle/right mouse button is pressed (Bug #14180)
---
 src/xfdesktop-icon-view.c | 40 ++++++++++++++++++++++------------------
 1 file changed, 22 insertions(+), 18 deletions(-)

diff --git a/src/xfdesktop-icon-view.c b/src/xfdesktop-icon-view.c
index 732bac9..0bf5730 100644
--- a/src/xfdesktop-icon-view.c
+++ b/src/xfdesktop-icon-view.c
@@ -813,6 +813,24 @@ xfdesktop_icon_view_get_single_click(XfdesktopIconView *icon_view)
     return icon_view->priv->single_click;
 }
 
+static void
+xfdesktop_icon_view_clear_drag_event(XfdesktopIconView *icon_view, GtkWidget *widget)
+{
+    DBG("unsetting stuff");
+    icon_view->priv->control_click = FALSE;
+    icon_view->priv->double_click = FALSE;
+    icon_view->priv->maybe_begin_drag = FALSE;
+    icon_view->priv->definitely_dragging = FALSE;
+    if(icon_view->priv->definitely_rubber_banding) {
+        /* Remove the rubber band selection box */
+        icon_view->priv->definitely_rubber_banding = FALSE;
+        gtk_widget_queue_draw_area(widget, icon_view->priv->band_rect.x,
+                                   icon_view->priv->band_rect.y,
+                                   icon_view->priv->band_rect.width,
+                                   icon_view->priv->band_rect.height);
+    }
+}
+
 static gboolean
 xfdesktop_icon_view_button_press(GtkWidget *widget,
                                  GdkEventButton *evt,
@@ -826,6 +844,10 @@ xfdesktop_icon_view_button_press(GtkWidget *widget,
     if(evt->type == GDK_BUTTON_PRESS) {
         GList *icon_l;
 
+        /* Clear drag event if ongoing */
+        if(evt->button == 2 || evt->button == 3)
+            xfdesktop_icon_view_clear_drag_event(icon_view, widget);
+
         /* Let xfce-desktop handle button 2 */
         if(evt->button == 2) {
             /* If we had the grab release it so the desktop gets the event */
@@ -973,24 +995,6 @@ xfdesktop_icon_view_get_tooltip_size(XfdesktopIconView *icon_view)
     return DEFAULT_TOOLTIP_SIZE;
 }
 
-static void
-xfdesktop_icon_view_clear_drag_event(XfdesktopIconView *icon_view, GtkWidget *widget)
-{
-    DBG("unsetting stuff");
-    icon_view->priv->control_click = FALSE;
-    icon_view->priv->double_click = FALSE;
-    icon_view->priv->maybe_begin_drag = FALSE;
-    icon_view->priv->definitely_dragging = FALSE;
-    if(icon_view->priv->definitely_rubber_banding) {
-        /* Remove the rubber band selection box */
-        icon_view->priv->definitely_rubber_banding = FALSE;
-        gtk_widget_queue_draw_area(widget, icon_view->priv->band_rect.x,
-                                   icon_view->priv->band_rect.y,
-                                   icon_view->priv->band_rect.width,
-                                   icon_view->priv->band_rect.height);
-    }
-}
-
 static gboolean
 xfdesktop_icon_view_button_release(GtkWidget *widget,
                                    GdkEventButton *evt,

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.