[Xfce4-commits] [xfce/xfconf] 01/01: tests: Explicitly handle error reply from Ping method call

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

s   k   u   n   n   y   k       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfconf.

commit b4bed38222aa0c389b6ded430bcdfade27e77f73
Author: Michał Górny <mgorny at gentoo.org>
Date:   Mon Jun 17 10:30:57 2019 +0200

    tests: Explicitly handle error reply from Ping method call
    
    Explicitly handle the possible error reply from D-Bus when issuing
    the Ping method call on xfconfd instance.  This can happen when xfconfd
    is unknown to D-Bus (e.g. not installed yet).  Explicit error replacing
    cryptic test failures with explicit error that xfconfd is not running.
    Fix bug #15616
---
 tests/tests-common.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/tests-common.h b/tests/tests-common.h
index f895cfb..b763aac 100644
--- a/tests/tests-common.h
+++ b/tests/tests-common.h
@@ -107,6 +107,14 @@ xfconf_tests_start(void)
             return FALSE;
         }
     }
+    if (g_dbus_message_get_message_type(ret) != G_DBUS_MESSAGE_TYPE_METHOD_RETURN)
+    {
+        g_critical("xfconfd is not running and can not be autostarted");
+        g_object_unref (msg);
+        g_object_unref (ret);
+        xfconf_tests_end();
+        return FALSE;
+    }
     g_object_unref (msg);
     g_object_unref (ret);
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.