[Xfce4-commits] [xfce/xfwm4] 01/01: settings-dialog: Clear shortcut in treeview

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   l   i   v   i   e   r       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfwm4.

commit 464e152297c75354c58f1661fc9aa6cf9d417706
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Mon Jun 17 21:06:23 2019 +0200

    settings-dialog: Clear shortcut in treeview
    
    Bug: 12802
    
    Clearing a shortcut in the UI would rightfully remove the shortcut
    definition, but would not clear the corresponding entry in the treeview.
    
    Clear the shortcut entry in the treeview so that users are not left
    thinking the clear action didn't do anything.
    
    Signed-off-by: Olivier Fourdan <fourdan at xfce.org>
---
 settings-dialogs/xfwm4-settings.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/settings-dialogs/xfwm4-settings.c b/settings-dialogs/xfwm4-settings.c
index 5d8fbca..8d78972 100644
--- a/settings-dialogs/xfwm4-settings.c
+++ b/settings-dialogs/xfwm4-settings.c
@@ -2112,7 +2112,12 @@ xfwm_settings_shortcut_row_activated (GtkTreeView       *tree_view,
         {
           /* Remove old shortcut from the settings */
           if (G_LIKELY (shortcut != NULL))
-            xfce_shortcuts_provider_reset_shortcut (settings->priv->provider, shortcut);
+            {
+              xfce_shortcuts_provider_reset_shortcut (settings->priv->provider, shortcut);
+              gtk_list_store_set (GTK_LIST_STORE (model), &iter,
+                                  SHORTCUTS_SHORTCUT_COLUMN, NULL,
+                                  SHORTCUTS_SHORTCUT_LABEL_COLUMN, NULL, -1);
+            }
         }
 
       /* Destroy the shortcut dialog */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.