[Xfce4-commits] [apps/xfce4-screensaver] 01/01: Fix CID 213287: Unchecked return value

noreply at xfce.org noreply at xfce.org
Fri Jun 7 03:51:54 CEST 2019


This is an automated email from the git hooks/post-receive script.

b   l   u   e   s   a   b   r   e       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository apps/xfce4-screensaver.

commit d0ecee37a59b56452689742c12183cc18ee8dd73
Author: Sean Davis <smd.seandavis at gmail.com>
Date:   Thu Jun 6 21:51:49 2019 -0400

    Fix CID 213287: Unchecked return value
---
 src/gs-theme-manager.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/gs-theme-manager.c b/src/gs-theme-manager.c
index fb19df6..5ca5a0b 100644
--- a/src/gs-theme-manager.c
+++ b/src/gs-theme-manager.c
@@ -107,18 +107,18 @@ find_command (const char *command) {
 
 static gboolean
 check_command (const char *command) {
-    char *path;
     char **argv;
 
     g_return_val_if_fail (command != NULL, FALSE);
 
-    g_shell_parse_argv (command, NULL, &argv, NULL);
-    path = find_command (argv[0]);
-    g_strfreev (argv);
+    if (g_shell_parse_argv (command, NULL, &argv, NULL)) {
+        char *path = find_command (argv[0]);
+        g_strfreev (argv);
 
-    if (path != NULL) {
-        g_free (path);
-        return TRUE;
+        if (path != NULL) {
+            g_free (path);
+            return TRUE;
+        }
     }
 
     return FALSE;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list