[Xfce4-commits] [xfce/xfce4-panel] 01/02: tic-tac-toe: Avoid use-after-free/double-free (Bug #15649)

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   c   h   o   s   i       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfce4-panel.

commit d04a412c072ee94a29fa14894cf46cfada2c60a2
Author: Olivier Fourdan <ofourdan at redhat.com>
Date:   Mon Jul 1 14:52:26 2019 +0200

    tic-tac-toe: Avoid use-after-free/double-free (Bug #15649)
    
    Clicking on the easter egg “tic-tac-toe” would crash the panel.
    
    Avoid the use-after-free/double-free by not destroying the dialog in
    the email hook.
    
    Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
---
 panel/panel-dialogs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/panel/panel-dialogs.c b/panel/panel-dialogs.c
index 84dd27e..2349dbb 100644
--- a/panel/panel-dialogs.c
+++ b/panel/panel-dialogs.c
@@ -48,7 +48,7 @@ panel_dialogs_show_about_email_hook (GtkAboutDialog *dialog,
       /* open tic-tac-toe */
       panel_tic_tac_toe_show ();
       /* close the about dialog as its modality will otherwise prevent you from playing */
-      gtk_widget_destroy (GTK_WIDGET (dialog));
+      gtk_widget_hide (GTK_WIDGET (dialog));
       return TRUE;
     }
   else if (!gtk_show_uri_on_window (GTK_WINDOW (dialog),

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.