[Xfce4-commits] [panel-plugins/xfce4-places-plugin] 07/30: Replace style-set signal by style-updated and disable it

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

b   l   u   e   s   a   b   r   e       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository panel-plugins/xfce4-places-plugin.

commit 6f09203719f03de80942ec0b0700deec76c199ab
Author: Andre Miranda <andreldm at xfce.org>
Date:   Wed Jan 2 09:25:40 2019 -0300

    Replace style-set signal by style-updated and disable it
    
    Both signals (mis)behave likewise.
---
 panel-plugin/view.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/panel-plugin/view.c b/panel-plugin/view.c
index 64474d5..a586c04 100644
--- a/panel-plugin/view.c
+++ b/panel-plugin/view.c
@@ -935,8 +935,13 @@ places_view_init(XfcePanelPlugin *plugin)
     pview_button_update(view);
 
     /* signals for icon theme/screen changes */
-    g_signal_connect_swapped(view->button, "style-set",
-                             G_CALLBACK(pview_destroy_menu), view);
+    /* FIXME: disable style-updated signal because it is fired whenever the
+       pointer moves over the button, so the menu is destroyed "faster" than
+       it is created. The downside is that now icons are not updated when
+       theme changes.
+    g_signal_connect_swapped(view->button, "style-updated",
+                              G_CALLBACK(pview_destroy_menu), view);
+    */
     g_signal_connect_swapped(view->button, "screen-changed",
                              G_CALLBACK(pview_destroy_menu), view);
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.