[Xfce4-commits] [xfce/xfwm4] 05/05: settings: Crash in button layout

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   l   i   v   i   e   r       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfwm4.

commit 60a8e49c8a63db47b8eb31618e0b6aa5be729a80
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Sun Apr 14 19:12:00 2019 +0200

    settings: Crash in button layout
    
    Bug: 14606
    
    `gdk_pixbuf_get_from_window()` crashes every other call in cairo, there
    are apparently a few similar reports.
    
    Just remove the call to `gdk_pixbuf_get_from_window()` as a workaround
    for now.
---
 settings-dialogs/xfwm4-settings.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/settings-dialogs/xfwm4-settings.c b/settings-dialogs/xfwm4-settings.c
index 0377a8b..ecdd3e8 100644
--- a/settings-dialogs/xfwm4-settings.c
+++ b/settings-dialogs/xfwm4-settings.c
@@ -1208,11 +1208,13 @@ xfwm_settings_title_button_press_event (GtkWidget *widget)
   GdkPixbuf *pixbuf;
 
   g_return_val_if_fail (GTK_IS_WIDGET (widget), TRUE);
-
+ /* FIXME! This crashes in cairo... xfce bug 14606 */
+#if 0
   /* set pixbuf before drag begin cause it can be not displayed */
   pixbuf = xfwm_settings_create_icon_from_widget (widget);
   gtk_drag_source_set_icon_pixbuf (widget, pixbuf);
   g_object_unref (pixbuf);
+#endif
 
   return TRUE;
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.