[Xfce4-commits] [xfce/xfdesktop] 01/01: Bug #15060: Fix xfdesktop crashes after multiples --reload

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

s   k   u   n   n   y   k       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfdesktop.

commit 1455a1780a89ca2253c2deb457e49b78df0555d8
Author: Romain B <skunnyk at alteroot.org>
Date:   Sat Mar 23 19:42:20 2019 +0100

    Bug #15060: Fix xfdesktop crashes after multiples --reload
    
    - Since the gtk3/gdbus port, xfdesktop crashes when trying to contact xfconfd after about 8 "--reload" commands
    - The crash only appears if Desktop Icons are enabled in settings
    - This patch workaround the situation by disabling the icon view reload on "--reload".
    - This does not seems to introduce any regressions.
---
 src/xfce-desktop.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/xfce-desktop.c b/src/xfce-desktop.c
index 6530610..069416e 100644
--- a/src/xfce-desktop.c
+++ b/src/xfce-desktop.c
@@ -1934,16 +1934,6 @@ xfce_desktop_refresh(XfceDesktop *desktop, gboolean advance_wallpaper)
     /* If we're only advancing the wallpaper we can exit here */
     if(advance_wallpaper)
         return;
-
-#ifdef ENABLE_DESKTOP_ICONS
-    /* reload icon view */
-    if(desktop->priv->icon_view) {
-        gtk_widget_destroy(desktop->priv->icon_view);
-        desktop->priv->icon_view = NULL;
-    }
-    xfce_desktop_setup_icon_view(desktop);
-#endif
-
 }
 
 void xfce_desktop_arrange_icons(XfceDesktop *desktop)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.