[Xfce4-commits] [xfce/thunar] 01/01: Fixed compiler warning, removed unused code and added comment to probably unused motion_notify_event

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

a   l   e   x       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       x   f   c   e   -   4   .   1   4   
   in repository xfce/thunar.

commit 9f0c92db20fe5ea54e3dd8c21a284168ad257b28
Author: Alexander Schwinn <alexxcons at xfce.org>
Date:   Wed Sep 26 23:17:48 2018 +0200

    Fixed compiler warning, removed unused code and added comment to
    probably unused motion_notify_event
---
 thunar/thunar-standard-view.c | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/thunar/thunar-standard-view.c b/thunar/thunar-standard-view.c
index f8655a7..f2ce4e4 100644
--- a/thunar/thunar-standard-view.c
+++ b/thunar/thunar-standard-view.c
@@ -3073,9 +3073,6 @@ thunar_standard_view_motion_notify_event (GtkWidget          *view,
                                           GdkEventMotion     *event,
                                           ThunarStandardView *standard_view)
 {
-  GdkDragContext *context;
-  GtkTargetList  *target_list;
-
   _thunar_return_val_if_fail (THUNAR_IS_STANDARD_VIEW (standard_view), FALSE);
   _thunar_return_val_if_fail (standard_view->priv->drag_timer_id != 0, FALSE);
 
@@ -3085,20 +3082,10 @@ thunar_standard_view_motion_notify_event (GtkWidget          *view,
       /* cancel the drag timer, as we won't popup the menu anymore */
       g_source_remove (standard_view->priv->drag_timer_id);
 
-      /* allocate the drag context (preferred action is to ask the user) */
-      target_list = gtk_target_list_new (drag_targets, G_N_ELEMENTS (drag_targets));
-      context = gtk_drag_begin_with_coordinates (view, target_list,
-                                                 GDK_ACTION_COPY |
-                                                 GDK_ACTION_MOVE |
-                                                 GDK_ACTION_LINK |
-                                                 GDK_ACTION_ASK,
-                                                 3, (GdkEvent *) event, -1, -1);
-
       /* FIXME
-      gdk_drag_context_set_suggested_action (context, GDK_ACTION_ASK);
+       * - according to doc, the GdkWindow associated to the widget needs to enable the GDK_POINTER_MOTION_MASK mask to use this event.
+       * We dont do that. So possibly this is dead code, which can be removed ?
       */
-      gtk_target_list_unref (target_list);
-
       return TRUE;
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.