[Xfce4-commits] [xfce/tumbler] 01/01: Accept network paths in ffmpeg thumbnailer plugin

noreply at xfce.org noreply at xfce.org
Sun Sep 2 08:43:59 CEST 2018


This is an automated email from the git hooks/post-receive script.

a   l   i       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/tumbler.

commit 67900ce7aba3e3b4702add01088b00c89233b996
Author: Evangelos Foutras <evangelos at foutrelis.com>
Date:   Sun Jun 10 22:01:39 2018 +0300

    Accept network paths in ffmpeg thumbnailer plugin
    
    g_file_get_path() appears to be able to convert smb://, sftp://, and
    other GVFS schemes to local absolute paths which can be passed as is
    to ffmpegthumbnailer. In order to handle these URIs, remove the call
    to g_file_is_native() and rely exclussively on g_file_get_path().
---
 plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer.c b/plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer.c
index 04cbb9d..81f2922 100644
--- a/plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer.c
+++ b/plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer.c
@@ -196,14 +196,11 @@ ffmpeg_thumbnailer_create (TumblerAbstractThumbnailer *thumbnailer,
 
   uri = tumbler_file_info_get_uri (info);
 
-  /* try to open the source file for reading */
+  /* get the local absolute path to the source file */
   file = g_file_new_for_uri (uri);
+  path = g_file_get_path (file);
 
-  if (g_file_is_native (file))
-    {
-      path = g_file_get_path (file);
-    }
-  else
+  if (path == NULL)
     {
       /* there was an error, emit error signal */
       g_set_error (&error, TUMBLER_ERROR, TUMBLER_ERROR_INVALID_FORMAT,

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list