[Xfce4-commits] [apps/gigolo] 21/26: Drop additional widget refs since items are now hidden instead of removed from the table

noreply at xfce.org noreply at xfce.org
Thu Oct 25 08:04:13 CEST 2018


This is an automated email from the git hooks/post-receive script.

l   a   n   d   r   y       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository apps/gigolo.

commit 7b39b16d04c1586c7999d64f1963a57d8e2170cc
Author: Sean Davis <smd.seandavis at gmail.com>
Date:   Wed Oct 24 13:00:21 2018 -0400

    Drop additional widget refs since items are now hidden instead of removed from the table
---
 src/bookmarkeditdialog.c | 37 -------------------------------------
 1 file changed, 37 deletions(-)

diff --git a/src/bookmarkeditdialog.c b/src/bookmarkeditdialog.c
index 1e6fb20..b1b7ee8 100644
--- a/src/bookmarkeditdialog.c
+++ b/src/bookmarkeditdialog.c
@@ -166,22 +166,6 @@ static void gigolo_bookmark_edit_dialog_finalize(GObject *object)
 		priv->browse_host_signal_id = 0;
 	}
 
-	gtk_widget_destroy(priv->uri_entry);
-	gtk_widget_destroy(priv->uri_label);
-	gtk_widget_destroy(priv->host_entry);
-	gtk_widget_destroy(priv->host_label);
-	gtk_widget_destroy(priv->folder_entry);
-	gtk_widget_destroy(priv->folder_label);
-	gtk_widget_destroy(priv->port_label);
-	gtk_widget_destroy(priv->port_spin);
-	gtk_widget_destroy(priv->user_entry);
-	gtk_widget_destroy(priv->user_label);
-	gtk_widget_destroy(priv->domain_entry);
-	gtk_widget_destroy(priv->domain_label);
-	gtk_widget_destroy(priv->share_combo);
-	gtk_widget_destroy(priv->share_button);
-	gtk_widget_destroy(priv->share_label);
-
 	G_OBJECT_CLASS(gigolo_bookmark_edit_dialog_parent_class)->finalize(object);
 }
 
@@ -915,8 +899,6 @@ static GtkWidget *make_frame (const gchar *label)
 	formatted = g_markup_printf_escaped ("<b>%s</b>", label);
 	gtk_label_set_markup (GTK_LABEL (widget), formatted);
 
-	gtk_widget_show (frame);
-
 	return frame;
 }
 
@@ -1120,25 +1102,6 @@ static void gigolo_bookmark_edit_dialog_init(GigoloBookmarkEditDialog *dialog)
 	g_signal_connect(priv->path_entry, "activate", G_CALLBACK(entry_activate_cb), dialog);
 	g_signal_connect(priv->user_entry, "activate", G_CALLBACK(entry_activate_cb), dialog);
 
-	/* We need an extra ref so we can remove them from the table */
-	g_object_ref(priv->uri_entry);
-	g_object_ref(priv->uri_label);
-	g_object_ref(priv->host_entry);
-	g_object_ref(priv->host_label);
-	g_object_ref(priv->folder_entry);
-	g_object_ref(priv->folder_label);
-	g_object_ref(priv->path_entry);
-	g_object_ref(priv->path_label);
-	g_object_ref(priv->port_label);
-	g_object_ref(priv->port_spin);
-	g_object_ref(priv->user_entry);
-	g_object_ref(priv->user_label);
-	g_object_ref(priv->domain_entry);
-	g_object_ref(priv->domain_label);
-	g_object_ref(priv->share_combo);
-	g_object_ref(priv->share_button);
-	g_object_ref(priv->share_label);
-
 	gtk_widget_show_all(vbox);
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list