[Xfce4-commits] [apps/xfdashboard] 02/03: Fix overriding a binding in hash table as g_hash_table_insert preserves the already stored key and frees the passed one but g_hash_table_replace will free the already stored key and use the passed key instead.

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

n   o   m   a   d       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository apps/xfdashboard.

commit b712d58692b9dc261a58991a0585dd5343e57d86
Author: Stephan Haller <nomad at froevel.de>
Date:   Fri May 4 10:04:14 2018 +0200

    Fix overriding a binding in hash table as g_hash_table_insert preserves the already stored key and frees the passed one but g_hash_table_replace will free the already stored key and use the passed key instead.
    
    This commit addresses issue GH #167
---
 libxfdashboard/bindings-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libxfdashboard/bindings-pool.c b/libxfdashboard/bindings-pool.c
index 79015e4..c4ccba3 100644
--- a/libxfdashboard/bindings-pool.c
+++ b/libxfdashboard/bindings-pool.c
@@ -801,7 +801,7 @@ static void _xfdashboard_bindings_pool_merge_bindings(gpointer inKey,
 	/* Insert binding into target hash table which will either insert a new key
 	 * with the binding value or replaces the binding value at the existing key.
 	 */
-	g_hash_table_insert(targetBindingsHashTable, g_object_ref(binding), inValue);
+	g_hash_table_replace(targetBindingsHashTable, g_object_ref(binding), inValue);
 }
 
 /* Load bindings from XML file */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.