[Xfce4-commits] [xfce/thunar] 01/01: Fixed an uncritical "use after free" ( check if NULL after free ) Afaik it did not cause trouble so far.

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

a   l   e   x       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/thunar.

commit 95b78380cb866f7597ad467f99220aacf0cadc4a
Author: Alexander Schwinn <acs82 at gmx.de>
Date:   Sun Feb 18 20:42:43 2018 +0100

    Fixed an uncritical "use after free" ( check if NULL after free )
    Afaik it did not cause trouble so far.
---
 thunar/thunar-standard-view.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/thunar/thunar-standard-view.c b/thunar/thunar-standard-view.c
index c94c38d..2bddff8 100644
--- a/thunar/thunar-standard-view.c
+++ b/thunar/thunar-standard-view.c
@@ -4257,7 +4257,6 @@ thunar_standard_view_context_menu (ThunarStandardView *standard_view)
   /* merge the custom menu actions for the selected items */
   selected_items = (*THUNAR_STANDARD_VIEW_GET_CLASS (standard_view)->get_selected_items) (standard_view);
   thunar_standard_view_merge_custom_actions (standard_view, selected_items);
-  g_list_free_full (selected_items, (GDestroyNotify) gtk_tree_path_free);
 
   /* grab an additional reference on the view */
   g_object_ref (G_OBJECT (standard_view));
@@ -4266,6 +4265,8 @@ thunar_standard_view_context_menu (ThunarStandardView *standard_view)
   menu = gtk_ui_manager_get_widget (standard_view->ui_manager, (selected_items != NULL) ? "/file-context-menu" : "/folder-context-menu");
   thunar_gtk_menu_run (GTK_MENU (menu));
 
+  g_list_free_full (selected_items, (GDestroyNotify) gtk_tree_path_free);
+
   /* release the additional reference on the view */
   g_object_unref (G_OBJECT (standard_view));
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.