[Xfce4-commits] [xfce/xfwm4] 01/01: Add back the glXWaitGL to compositor sync code

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

o   l   i   v   i   e   r       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository xfce/xfwm4.

commit f75652eba37a3c6c3bfd2eeb78e3d21068a1931f
Author: Alistair Buxton <a.j.buxton at gmail.com>
Date:   Sun Dec 9 22:03:04 2018 +0000

    Add back the glXWaitGL to compositor sync code
    
    In d6e7fbc4 the glXWaitX/glXWaitGL synchronization around compositor
    texture upload was replaced by an XSync fence. This causes extreme
    flickering on nvidia. My current understanding is that the fence code
    is equivalent to glXWaitX, so the other half of the synchronization
    is not handled. This patch restores glXWaitGL to deal with that.
    
    Note that if my understanding is correct then this patch will
    behave exactly the same as reverting d6e7fbc4. This means the
    problems d6e7fbc4 intended to fix will come back.
    
    Note (bis), I do not see any regression with intel/modesettings so I
    reckon it's fine to land -- (ofourdan)
---
 src/compositor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/compositor.c b/src/compositor.c
index 1b09a59..7ade3fe 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -1584,6 +1584,8 @@ redraw_glx_texture (ScreenInfo *screen_info)
     glXReleaseTexImageEXT (myScreenGetXDisplay (screen_info),
                            screen_info->glx_drawable, GLX_FRONT_EXT);
 
+    glXWaitGL();
+
     check_gl_error();
 }
 #endif /* HAVE_EPOXY */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.