[Xfce4-commits] [panel-plugins/xfce4-pulseaudio-plugin] 01/01: Fix CID 168082: Dereference before null

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

b   l   u   e   s   a   b   r   e       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository panel-plugins/xfce4-pulseaudio-plugin.

commit a9610060fe0563eaf4b4e645d47e184a912a80eb
Author: Sean Davis <smd.seandavis at gmail.com>
Date:   Fri Sep 1 20:33:02 2017 -0400

    Fix CID 168082: Dereference before null
---
 panel-plugin/pulseaudio-mpris-player.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/panel-plugin/pulseaudio-mpris-player.c b/panel-plugin/pulseaudio-mpris-player.c
index c07eb37..199f78c 100644
--- a/panel-plugin/pulseaudio-mpris-player.c
+++ b/panel-plugin/pulseaudio-mpris-player.c
@@ -518,13 +518,10 @@ pulseaudio_mpris_player_set_player (PulseaudioMprisPlayer *player,
     }
 
   /* Set new player and connect again */
-  if (player != NULL)
-    {
-      player->player = g_strdup(player_name);
+  player->player = g_strdup(player_name);
 
-      pulseaudio_mpris_player_set_details_from_desktop (player, player_name);
-      pulseaudio_mpris_player_dbus_connect (player);
-    }
+  pulseaudio_mpris_player_set_details_from_desktop (player, player_name);
+  pulseaudio_mpris_player_dbus_connect (player);
 }
 
 static void

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.