[Xfce4-commits] [apps/xfdashboard] 01/04: Revert commit 1b02280bb6999d3c68f8fdaa25a1cde5e428ec0b as it renders pop-up menu at application buttons in quicklaunch unreachable.

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

n   o   m   a   d       p   u   s   h   e   d       a       c   o   m   m   i   t       t   o       b   r   a   n   c   h       m   a   s   t   e   r   
   in repository apps/xfdashboard.

commit 403bb4b03dfa1bc0584c86dbe0339e6a8c433242
Author: Stephan Haller <nomad at froevel.de>
Date:   Mon Oct 23 07:38:08 2017 +0200

    Revert commit 1b02280bb6999d3c68f8fdaa25a1cde5e428ec0b as it renders pop-up menu at application buttons in quicklaunch unreachable.
    
    This commit moved pop-up menus being shown only on left-clicks (and touchscreen taps) instead of right clicks and the left click is first handled by application button activation event handler, usually starting the application and quitting xfdashboard. So pop-up menus are never reached.
    
    Reverting this commit turns on right-clicks again.
---
 libxfdashboard/quicklaunch.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/libxfdashboard/quicklaunch.c b/libxfdashboard/quicklaunch.c
index 7770a23..f73bbbf 100644
--- a/libxfdashboard/quicklaunch.c
+++ b/libxfdashboard/quicklaunch.c
@@ -671,10 +671,8 @@ static void _xfdashboard_quicklaunch_on_favourite_popup_menu(XfdashboardQuicklau
 	appButton=XFDASHBOARD_APPLICATION_BUTTON(inActor);
 	action=XFDASHBOARD_CLICK_ACTION(inUserData);
 
-	/* Only emit any of these signals if click was perform with left button 
-	 * or is a short touchscreen touch event.
-	 */
-	if(xfdashboard_click_action_is_left_button_or_tap(action))
+	/* Check if right button was used when the application button was clicked */
+	if(xfdashboard_click_action_get_button(action)==XFDASHBOARD_CLICK_ACTION_RIGHT_BUTTON)
 	{
 		ClutterActor							*popup;
 		ClutterActor							*menuItem;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.